-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC-DA-1.2: Better error messages #35916
Merged
andy31415
merged 3 commits into
project-chip:master
from
cecille:tc_da_1_2_better_error_message
Oct 15, 2024
Merged
TC-DA-1.2: Better error messages #35916
andy31415
merged 3 commits into
project-chip:master
from
cecille:tc_da_1_2_better_error_message
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test: Added a bad der file in the cd-certs dir, saw failure on ToT, no failure with this fix.
Review changes with SemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is 25% smaller than the GitHub diff.
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
labels
Oct 4, 2024
pullapprove
bot
added
review - pending
and removed
tests
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
labels
Oct 4, 2024
PR #35916: Size comparison from 78f489d to 607fab9 Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
labels
Oct 4, 2024
PR #35916: Size comparison from 78f489d to 3785ea8 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #35916: Size comparison from 78f489d to ef8d846 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
Oct 10, 2024
raju-apple
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast track
matter-1.4-te2-script-change
Script changes before end of Matter 1.4 TE2
review - pending
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: Added a bad der file in the cd-certs dir, saw failure on
ToT, no failure with this fix.